-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to state manager and redis datastore schema #1489
Changes to state manager and redis datastore schema #1489
Conversation
* Remove gcp dependencies * Update dockerfiles * Update dockerfiles * Update gcp error reporting * Updates to formatting * Add unit test * Update unit test * Clean up * Update unit test * Update error reporting * Update file * Update config template * Catch exception * Updates * fix lint
updated-dependencies: - dependency-name: requests dependency-type: indirect dependency-group: pip - dependency-name: requests dependency-type: indirect dependency-group: pip ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Please ignore changes to files under |
Bumps the pip group with 1 update in the / directory: [requests](https://github.com/psf/requests). Bumps the pip group with 1 update in the /turbinia/api/cli directory: [requests](https://github.com/psf/requests). Updates `requests` from 2.32.0 to 2.32.3 - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.0...v2.32.3) Updates `requests` from 2.32.0 to 2.32.3 - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.0...v2.32.3) --- updated-dependencies: - dependency-name: requests dependency-type: indirect dependency-group: pip - dependency-name: requests dependency-type: indirect dependency-group: pip ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from web ui side per our side chats around it. As discussed, will leave the truncate of statuses as is to fix issues with table being too long and look at a later time for a way to size the virtual scroll to the table width.
Quick update: I started reading through this today and will work on finishing the review tomorrow! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just some small nits/comments.
* Set celery task limits and fix worker timeout * Remove solo pool and change concurrency=1 * Add soft/hard limit buffers * Fix server timeout * Late import for psutil * small fixes, tests * fix run tests * test format string * Fix process_result test * fix execute test * revert unnecessary config changes * Handle soft timeout exception in execute() * update timeout message * Yaaaaaaaapf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple nits in comments and a question.
0588367
into
google:redis-hashed-requests-and-tasks
* Added the TurbiniaRequest hashed object in Redis * Converted TurbiniaTasks to hash objects in Redis * Made get_request_data more efficient * Made get_requests_summary more efficient * Fixed some issues in request_status * Remove GCP dependencies (#1440) * Remove gcp dependencies * Update dockerfiles * Update dockerfiles * Update gcp error reporting * Updates to formatting * Add unit test * Update unit test * Clean up * Update unit test * Update error reporting * Update file * Update config template * Catch exception * Updates * fix lint * Lint fixes * Updates * Updates * Various updates and fixes * Updates * --- (#1483) updated-dependencies: - dependency-name: requests dependency-type: indirect dependency-group: pip - dependency-name: requests dependency-type: indirect dependency-group: pip ... * Updates * Update typo * Updates to unit tests * Updates to unit tests and linter fixes * Update table width UI * Bump the pip group across 2 directories with 1 update (#1487) Bumps the pip group with 1 update in the / directory: [requests](https://github.com/psf/requests). Bumps the pip group with 1 update in the /turbinia/api/cli directory: [requests](https://github.com/psf/requests). Updates `requests` from 2.32.0 to 2.32.3 - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.0...v2.32.3) Updates `requests` from 2.32.0 to 2.32.3 - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.0...v2.32.3) --- updated-dependencies: - dependency-name: requests dependency-type: indirect dependency-group: pip - dependency-name: requests dependency-type: indirect dependency-group: pip ... * Fix small UI bug * Minor typos/errors * Set celery task limits and fix worker timeout (#1486) * Set celery task limits and fix worker timeout * Remove solo pool and change concurrency=1 * Add soft/hard limit buffers * Fix server timeout * Late import for psutil * small fixes, tests * fix run tests * test format string * Fix process_result test * fix execute test * revert unnecessary config changes * Handle soft timeout exception in execute() * update timeout message * Yaaaaaaaapf * Review fixes * Updates and yapf fix * Minor updates * Update docstrings * Updates to evidence_size * Updates * Change log level for message * Lint * bug fixes * Address review comments * Fix docstrings * Minor UI update --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Igor Rodrigues <igormr@nyu.edu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aaron Peterson <aaronp@gmail.com>
Description of the change
This pull request makes changes to the schema used to store Turbinia metadata in Redis. We are introducing a new key for Turbinia requests and changing TurbiniaTask keys to redis hashes instead of strings for optimization purposes.
Minor changes to the web UI.
Note: This is a breaking change. Redis databases from previous versions will not be compatible.
Applicable issues
Additional information
Checklist