Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up turbiniactl and other minor updates #1463

Merged
merged 23 commits into from
Apr 4, 2024
Merged

Clean up turbiniactl and other minor updates #1463

merged 23 commits into from
Apr 4, 2024

Conversation

jleaniz
Copy link
Collaborator

@jleaniz jleaniz commented Apr 2, 2024 •
edited
Loading

Description of the change

This pull request includes various changes:

  • Remove functionality from turbiniactl that has been either deprecated or has been migrated over to turbinia-client
  • Update turbiniactl unit tests
  • Update turbinia unit tests dockerfile
  • The e2e/e2e-local.sh script is updated to use turbinia-client instead of turbiniactl for running e2e tests.
  • Remove an extra logging statement from api_server.py that is not necessary since we instantiate the API server through turbiniactl (avoids duplicate logging)
  • Added github badges for e2e/unit test status to README.md

Applicable issues

  • N/A

Additional information

Checklist

  • All tests were successful.
  • Unit tests added.
  • Documentation updated.

@jleaniz jleaniz self-assigned this Apr 2, 2024
@jleaniz jleaniz changed the title Clean up turbiniactl Clean up turbiniactl and update e2e tests Apr 3, 2024
@jleaniz jleaniz changed the title Clean up turbiniactl and update e2e tests Clean up turbiniactl and other minor updates Apr 3, 2024
@jleaniz jleaniz marked this pull request as ready for review April 3, 2024 03:20
@jleaniz jleaniz requested a review from aarontp April 3, 2024 14:30
aarontp
aarontp approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@aarontp aarontp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great to see this old code deleted!

@aarontp aarontp merged commit 435de73 into google:master Apr 4, 2024
5 checks passed
@jleaniz jleaniz mentioned this pull request May 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarontp aarontp aarontp approved these changes

Assignees

@jleaniz jleaniz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleaniz @aarontp