Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check to e2e test to verify all containers come up. #1389

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

hacktobeer
Copy link
Collaborator

@hacktobeer hacktobeer commented Nov 7, 2023

Description of the change

Add check to e2e test to verify all containers come up.

Applicable issues

Checklist

  • All tests were successful.
  • [NA] Unit tests added.
  • [NA] Documentation updated.

@hacktobeer
Copy link
Collaborator Author

e2e test fails as expected (as worker not comgin up) -> https://github.com/google/turbinia/actions/runs/6783407198/job/18437581229?pr=1389#step:10:25

After merging PR #1387 the e2e tests for this PR should finish with success as expected.

Copy link
Collaborator

@jleaniz jleaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hacktobeer hacktobeer merged commit 9aa1814 into google:master Nov 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: e2e tests are reporting succes while failing
2 participants