Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter ContainerEnumeration output #1351

Merged
merged 11 commits into from
Nov 16, 2023
Merged

Filter ContainerEnumeration output #1351

merged 11 commits into from
Nov 16, 2023

Conversation

aarontp
Copy link
Member

@aarontp aarontp commented Sep 30, 2023 •
edited
Loading

Description of the change

Filters the output of ContainerEnumeration Task to remove any system containers and any containers with names or images that are known to be system related in order to reduce the Evidence/Task count noise with containers that we rarely will need to inspect.

Also:

  • Has TASK_CONFIG vars for these filters so we can update them with a recipe
  • Adds a utility to list the namespaces and containers for a given cluster to make it easier to update this list in the future.
  • Adds container evidence attributes for pod name and image name and includes them in the image name for readability

Applicable issues

Additional information

Checklist

  • All tests were successful.
  • Unit tests added.
  • Documentation updated.

@aarontp aarontp added the WIP Work in progress label Sep 30, 2023
@aarontp aarontp removed the WIP Work in progress label Nov 16, 2023
@aarontp aarontp requested a review from jleaniz November 16, 2023 22:55
jleaniz
jleaniz approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@jleaniz jleaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two minor comments/qustions.

turbinia/evidence.py Show resolved Hide resolved
@aarontp aarontp marked this pull request as ready for review November 16, 2023 23:25
@jleaniz jleaniz merged commit 14f98f8 into google:master Nov 16, 2023
5 checks passed
@aarontp aarontp deleted the filter-containers-new branch November 16, 2023 23:40
jleaniz pushed a commit to jleaniz/turbinia that referenced this pull request Feb 28, 2024
@aarontp @jleaniz
Filter ContainerEnumeration output (google#1351)
f2ea43a 
* Filter ContainerEnumeration output

* Fix syntax/formatting

* Fix var name

* Update log messages

* Add more filters, update messages

* Fix image filter

* Update container evidence names and enumeration report

* update summary message

* yapf

* Set UnknownImageName if no image name exists

* Add default container/namespace values
jleaniz pushed a commit to jleaniz/turbinia that referenced this pull request Mar 18, 2024
@aarontp @jleaniz
Filter ContainerEnumeration output (google#1351)
0bdbb57 
* Filter ContainerEnumeration output

* Fix syntax/formatting

* Fix var name

* Update log messages

* Add more filters, update messages

* Fix image filter

* Update container evidence names and enumeration report

* update summary message

* yapf

* Set UnknownImageName if no image name exists

* Add default container/namespace values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleaniz jleaniz jleaniz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter Container/Docker enumeration output
2 participants
@aarontp @jleaniz