-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter ContainerEnumeration output #1351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleaniz
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, two minor comments/qustions.
jleaniz
reviewed
Nov 16, 2023
jleaniz
pushed a commit
to jleaniz/turbinia
that referenced
this pull request
Feb 28, 2024
* Filter ContainerEnumeration output * Fix syntax/formatting * Fix var name * Update log messages * Add more filters, update messages * Fix image filter * Update container evidence names and enumeration report * update summary message * yapf * Set UnknownImageName if no image name exists * Add default container/namespace values
jleaniz
pushed a commit
to jleaniz/turbinia
that referenced
this pull request
Mar 18, 2024
* Filter ContainerEnumeration output * Fix syntax/formatting * Fix var name * Update log messages * Add more filters, update messages * Fix image filter * Update container evidence names and enumeration report * update summary message * yapf * Set UnknownImageName if no image name exists * Add default container/namespace values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Filters the output of ContainerEnumeration Task to remove any system containers and any containers with names or images that are known to be system related in order to reduce the Evidence/Task count noise with containers that we rarely will need to inspect.
Also:
Applicable issues
Additional information
Checklist