Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of nsync used by TensorFlow to version 1.29.2 #2368

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Jun 27, 2024

Update version of nsync used by TensorFlow to version 1.29.2

TensorFlow previously imported nsync 1.27.0.

The changes to nsync since then are:

  • An update the the bazel BUILD file to use the "@platforms" mechanism to
    select source code depending on architecture and operating system.
    (Strangely, the "@platforms" mechanism still doesn't accommodate
    compiler-specific parameterization. It is accommodated using the
    "@bazel_tools//tools/cpp:compiler" setting.)

  • A change to CMakeLists.txt to add export targets for the C and C++ libraries.

  • A fix in nsync_semaphore_futex.c to allow the use of 64-bit time_t on 32-bit
    Linux systems, and to allow compilation to succeed for 32-bit RISC-V,
    which supports only 64-bit time_t (unlike most 32-bit Linux systems).

  • A fix to include stdlib.h in the Windows-specific file
    nsync_semaphore_win32.c, to avoid a compiler warning.

@copybara-service copybara-service bot changed the title Update version of nsync used by TensorFlow to version 1.29.1 Update version of nsync used by TensorFlow to version 1.29.2 Jun 28, 2024
TensorFlow previously imported nsync 1.27.0.

The changes to nsync since then are:

- An update the the bazel BUILD file to use the "@platforms" mechanism to
  select source code depending on architecture and operating system.
  (Strangely, the "@platforms" mechanism still doesn't accommodate
  compiler-specific parameterization.  It is accommodated using the
  "@bazel_tools//tools/cpp:compiler" setting.)

- A change to CMakeLists.txt to add export targets for the C and C++ libraries.

- A fix in nsync_semaphore_futex.c to allow the use of 64-bit time_t on 32-bit
  Linux systems, and to allow compilation to succeed for 32-bit RISC-V,
  which supports only 64-bit time_t (unlike most 32-bit Linux systems).

- A fix to include stdlib.h in the Windows-specific file
  nsync_semaphore_win32.c, to avoid a compiler warning.

PiperOrigin-RevId: 646202486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant