Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin all usages of golangci-lint to same rule version #2945

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Pin all usages of golangci-lint to same rule version #2945

merged 1 commit into from
Mar 21, 2023

Conversation

mhutchinson
Copy link
Contributor

No description provided.

@mhutchinson mhutchinson requested a review from a team as a code owner March 21, 2023 10:54
@mhutchinson
Copy link
Contributor Author

@JAORMX FYI. I think it makes sense to run explicitly the same version of the linter over this code as the rest of the repo.

@JAORMX
Copy link
Collaborator

JAORMX commented Mar 21, 2023

@JAORMX FYI. I think it makes sense to run explicitly the same version of the linter over this code as the rest of the repo.

It does! Thanks for looking into this!

@mhutchinson mhutchinson merged commit 4f5d7d1 into google:master Mar 21, 2023
@mhutchinson mhutchinson deleted the golangci-lint-pin branch March 21, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hickford hickford hickford approved these changes

@AlCutter AlCutter Awaiting requested review from AlCutter AlCutter is a code owner automatically assigned from google/trillian-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhutchinson @JAORMX @hickford