-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new optional fields for Text-to-Speech functionality in Service Alerts feed #135
Add new optional fields for Text-to-Speech functionality in Service Alerts feed #135
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
i signed it!
…---
Ritesh Warade
Director, IBI Group
617.699.9544
________________________________
From: googlebot <notifications@github.com>
Sent: Thursday, January 10, 2019 5:47:34 PM
To: google/transit
Cc: TransitRealtime; Author
Subject: Re: [google/transit] Add new optional field for Text-to-Speech functionality in Service Alerts feed: tts_ivr (#135)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
________________________________
What to do if you already signed the CLA
Individual signers
* It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data<https://cla.developers.google.com/clas> and verify that your email is set on your git commits<https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
* Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot<http://go/cla#troubleshoot> (Public version<https://opensource.google.com/docs/cla/#troubleshoot>).
* The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data<https://cla.developers.google.com/clas> and verify that your email is set on your git commits<https://help.github.com/articles/setting-your-email-in-git/>.
* The email used to register you as an authorized contributor must also be attached to your GitHub account<https://github.com/settings/emails>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#135 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ARwac-M1MZnfywg2IaHwCSVUyuof1wmSks5vB8MGgaJpZM4Z6d7z>.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
I'm a commit author and I'm ok with my commits being contributed to this project. |
I agree with the fields, their names and their definitions. Two small suggestions:
|
This pull request has been open for more than one week, so we are calling for a vote. Voting will be closed on Tuesday January 29 at 23:59:59 UTC. |
+1 |
+1 Pinging:
|
(That was a +1) |
+0. We don't have a problem with this field, but aren't likely to incorporate it into how we use Text-to-speech for alerts. |
@ibi-group-team One point of clarity - I believe this vote is for adopting the I'm +1 for adopting as experimental field. |
Voting for this proposal is closed and the results are: So the proposal passes! We'll get this merged. Thank you all! |
@google-admin @googlebot the CLA check is currently failing so this cannot be merged. @farah-machlab-ibigroup's contributions are covered under the corporate CLA for IBI Group. Can you please confirm and update the check? |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
Thanks @ibi-group-team and all for coming to a consensus on this! |
This is a proposal to add two new optional fields for text-to-speech functionality to the ServiceAlerts feed, called tts_header_text and tts_description_text of type TranslatedString.
See discussion here: #132
Announced on the GTFS-realtime Google Groups here: https://groups.google.com/forum/#!topic/gtfs-realtime/aI7OfMycsHw