Added support for go-sql-driver

[Thiyagu55]

This PR implements support for QueryRow method and QueryContext method

Usage
Import sqlcommentergo and use it's db driver

db, err := sqlcommenterGo.Open("mysql", "root:root@/gotest", sqlcommenter.CommenterOptions{EnableDBDriver: true, EnableTraceparent: true})

bsp := sdktrace.NewSimpleSpanProcessor(exp) // Create and add span processor
	tp := sdktrace.NewTracerProvider(
		sdktrace.WithSampler(sdktrace.AlwaysSample()),
		sdktrace.WithSpanProcessor(bsp),
	)

	propgator := propagation.NewCompositeTextMapPropagator(propagation.TraceContext{}, propagation.Baggage{})

	ctx, span := tp.Tracer("foo").Start(context.Background(), "parent-span-name")
	defer span.End()

	db.AddorUpdateCurrentSpan(ctx)
	

For http-router middleware implementation

// middleware is used to intercept incoming HTTP calls and apply general functions upon them.
func middleware(n httprouter.Handle) httprouter.Handle {
	return func(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {
		ctx := sqlcommenter.AddHttpRouterTags(r)
		log.Printf("HTTP request sent to %s from %s", r.URL.Path, r.RemoteAddr)

		// call registered handler
		n(w, r.WithContext(ctx), ps)
	}
}

• dbDriver is static and will be set by the sqlcommenter
• route needs to be passed via context

[sjs994]

Hi Thiyagu, Have updated few files. Please verify that things looks right.

[Thiyagu55]

It looks good

On Fri, 23 Sep 2022 at 7:03 PM, Subhrajyoti ***@***.***> wrote: Hi Thiyagu, Have updated few files. Please verify that things looks right. — Reply to this email directly, view it on GitHub <#161 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APLZWLBXS6QP2XZYQNG5PMDV7WWSZANCNFSM6AAAAAAQQAPSY4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- [image: User Image] [image: LinkedIn] <https://www.linkedin.com/company/searceinc/>[image: YouTube] <https://www.youtube.com/channel/UCo5Glw9EniPolbN0bR9VnBg>[image: Twitter] <https://twitter.com/searce> Thiyagu Nataraj Lead Software Engineer M:+91-9171767385 www.searce.com <https://searce.com/> [image: Searce Logo] <https://searce.com/> solving for better The information contained in this communication is intended solely for the use of the individual or entity to whom it is addressed and others authorized to receive it. It may contain confidential or legally privileged information. If you are not the intended recipient you are hereby notified that any disclosure, copying, distribution or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful. If you have received this communication in error, please notify us immediately by responding to this email and then delete it from your system. Searce is neither liable for the proper and complete transmission of the information contained in this communication nor for any delay in its receipt.

[sjs994]

Please resolve the comments as they may not be required after the last commit.

[sjs994]

This OTEL propagation model will not work. Please do the needful change.

[sjs994]

Overall looks okay.

How much effort will it be to move all these into a folder one level down go/go-sql ?
This is now under go folder, but the implementation is only for go database/sql. It's better to separate it in my opinion from start.

[bdewater]

This is missing escaping % like Python and PHP.

Why not use the same examples their test suites and are shown on the public docs, i.e. testing congo=t61rcWkgMzE,rojo=00f067aa0ba902b7 becomes congo%%3Dt61rcWkgMzE%%2Crojo%%3D00f067aa0ba902b7.

Edit: see #168 instead.