Strip build directory prefix in the __FILE__ macro #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various macros use __FILE__ to embed the source file name in errors/logs. However, the full path is encoder, making reproducible builds harder. This change uses the -fmacro-prefix-map of GCC >= 8.0 and clang >= 10.0 to remove the source directory prefix. Since only the prefix is removed, the relevant source file names are still included. Background: https://reproducible-builds.org/docs/build-path/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various macros use
__FILE__to embed the source file name inerrors/logs. However, the full path is encoder, making reproducible
builds harder.
This change uses the `-fmacro-prefix-map`` of GCC >= 8.0 and clang >= 10.0 to
remove the source directory prefix. Since only the prefix is removed, the
relevant source file names are still included.
Background:
https://reproducible-builds.org/docs/build-path/