Follow-on to google/pywrapcc#30093 (correction) #30098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcc40b2 Silly oversight: the `operator&() const` overload was missing in the test code.
rainwoodman
reviewed
Feb 7, 2024
tests/pybind11_tests.h
Outdated
| @@ -57,7 +57,9 @@ union IntFloat { | |||
| class UnusualOpRef { | |||
| public: | |||
| using NonTrivialType = std::shared_ptr<int>; // Almost any non-trivial type will do. | |||
| NonTrivialType operator&() { return non_trivial_member; } // UNUSUAL operator. | |||
| // UNUSUAL operators: | |||
There was a problem hiding this comment.
What about: "Overriding & operator should not break pybind11."
There was a problem hiding this comment.
Done (928b5b4). Thanks!
rainwoodman
approved these changes
Feb 7, 2024
rwgk
pushed a commit
to rwgk/pybind11
that referenced
this pull request
Jun 24, 2024
Includes follow-on to pybind#5189: Backport the smart_holder-specific changes from google/pybind11clif#30093 and google/pybind11clif#30098.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bring back
std::addressof(src)incorrectly removed with commit bcc40b2 (#30093).This fixes an oversight in #30093: the
operator&() constoverload was missing in the test code.Suggested changelog entry: