[MOVED] Add pybind11 IWYU pragmas (for clangd Include Cleaner). #30073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging and upstreaming this PR is deferred until Include Cleaner supports removing the "third_party/pybind11/include/" path name parts.
copybara-service bot
pushed a commit
to pybind/pybind11_protobuf
that referenced
this pull request
Oct 27, 2023
Adopt the ``` // IWYU pragma: always_keep // See pybind11/docs/type_caster_iwyu.rst ``` comment used in google/pybind11clif#30073. Currently pybind11/docs/type_caster_iwyu.rst only exists in google/pybind11clif#30073, but the intend is to upstream the changes (see PR description). See also: https://clangd.llvm.org/design/include-cleaner PiperOrigin-RevId: 577074824
copybara-service bot
pushed a commit
to pybind/pybind11_protobuf
that referenced
this pull request
Oct 31, 2023
Adopt the ``` // IWYU pragma: always_keep // See pybind11/docs/type_caster_iwyu.rst ``` comment used in google/pybind11clif#30073. Currently pybind11/docs/type_caster_iwyu.rst only exists in google/pybind11clif#30073, but the intend is to upstream the changes (see PR description). See also: https://clangd.llvm.org/design/include-cleaner PiperOrigin-RevId: 577074824
copybara-service bot
pushed a commit
to pybind/pybind11_abseil
that referenced
this pull request
Oct 31, 2023
…ingly. The header was meant to be deprecated for >1 year, but this was not documented. Also adopt the ``` // IWYU pragma: always_keep // See pybind11/docs/type_caster_iwyu.rst ``` comment used in google/pybind11clif#30073. Currently pybind11/docs/type_caster_iwyu.rst only exists in google/pybind11clif#30073, but the intend is to upstream the changes (see PR description). See also: https://clangd.llvm.org/design/include-cleaner PiperOrigin-RevId: 578314470
copybara-service bot
pushed a commit
to pybind/pybind11_protobuf
that referenced
this pull request
Oct 31, 2023
Adopt the ``` // IWYU pragma: always_keep // See pybind11/docs/type_caster_iwyu.rst ``` comment used in google/pybind11clif#30073. Currently pybind11/docs/type_caster_iwyu.rst only exists in google/pybind11clif#30073, but the intend is to upstream the changes (see PR description). See also: https://clangd.llvm.org/design/include-cleaner PiperOrigin-RevId: 578318836
added 5 commits
December 19, 2023 20:49
…cord_pyobject.h, google#30099).
rwgk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Continued under #30113]
This PR is the source of truth for google3_iwyu_pragmas.patch
Merging and upstreaming this PR is deferred until the clangd Include Cleaner supports removing the "third_party/pybind11/include/" path name parts.
For easy future reference: commit 9e5f44d here was submitted as cl/577013593.
Suggested changelog entry: