Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an error if both license scanning and local/offline scanning is enabled simultaneously #703

Merged

Conversation

another-rex
Copy link
Collaborator

When --local-db or --offline flags are passed in the user expects no requests containing individual packages to be made to an external service.

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (dd26cdc) 78.86% compared to head (f20fb30) 78.82%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/osvscanner/osvscanner.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
- Coverage   78.86%   78.82%   -0.04%     
==========================================
  Files          84       84              
  Lines        5943     5946       +3     
==========================================
  Hits         4687     4687              
- Misses       1054     1056       +2     
- Partials      202      203       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@another-rex another-rex merged commit cc94108 into google:main Dec 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants