Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igraph: disable aarch64 #11932

Merged
merged 1 commit into from
May 9, 2024
Merged

igraph: disable aarch64 #11932

merged 1 commit into from
May 9, 2024

Conversation

szhorvat
Copy link
Contributor

@szhorvat szhorvat commented May 9, 2024

I originally added this to make it easier to reproduce issues with Docker on Apple Silicon machines, but it broke the build. It seems OSS-Fuzz uses cross-compilation? It's possible to make this work for igraph, but I'm not ready to do it now given that aarch64 support is not even finalized in OSS-Fuzz.

Copy link

github-actions bot commented May 9, 2024

szhorvat (verified) is either the primary contact or is in the CCs list of projects/igraph.

@jonathanmetzman
Copy link
Contributor

I think this is the right move for now. Sorry about the incomplete support. We don't have any definite plans yet but I'd like to finish support this year.

@jonathanmetzman
Copy link
Contributor

I'm going ot look at the build failure. I bet it's because of the compiler roll. We don't cross compile btw

@jonathanmetzman
Copy link
Contributor

I stand corrected. I think compilation is being done using x-compilation.

@jonathanmetzman jonathanmetzman merged commit 889d0c5 into google:master May 9, 2024
16 checks passed
@szhorvat
Copy link
Contributor Author

szhorvat commented May 9, 2024

The build failure is here: https://oss-fuzz-build-logs.storage.googleapis.com/log-dcbafce1-1352-438f-9ab6-f56ef721823e.txt

The build system tries to compile and run an executable, and running it fails somehow. We do have a way to skip running this executable, but then there's a second one that I'd need to deal with as well and manually specify the output it would produce. Doing that felt like too much of a complication.

Your PR #10967 seemed to be promising for making things work on Apple Silicon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants