Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: msan enable PIC #11917

Merged
merged 3 commits into from
May 9, 2024
Merged

infra: msan enable PIC #11917

merged 3 commits into from
May 9, 2024

Conversation

maflcko
Copy link
Contributor

@maflcko maflcko commented May 7, 2024

Not sure why LLVM_ENABLE_PIC needs to be enabled manually. It should be by default, according to https://llvm.org/docs/CMake.html#llvm-related-variables

Copy link

github-actions bot commented May 7, 2024

maflcko has previously contributed to projects/libraw. The previous PR was #11887
maflcko has previously contributed to projects/libplist. The previous PR was #11887
maflcko has previously contributed to projects/wabt. The previous PR was #11887

@jonathanmetzman
Copy link
Contributor

/gcbrun trial_build.py c c++ --fuzzing-engines libfuzzer --sanitizers memory address coverage

@maflcko
Copy link
Contributor Author

maflcko commented May 8, 2024

Trial result: https://github.com/google/oss-fuzz/pull/11917/checks?check_run_id=24698361240

Timed-out: Remaining builds: 7/445, defaultdict(<class 'list'>, {'cpuinfo': ['11f94836-e721-460c-a902-530efbca3684'], 'hdf5': ['e73914e6-8694-477f-a552-b847db5277be'], 'rabbitmq-c': ['33db8256-62f4-48d0-874f-de9e55403951'], 'libpng': ['708c09f7-43be-4340-92f1-ca732aaabff8'], 'libxls': ['09629877-6927-4f30-af64-6fb3c8f5e79b'], 'mpg123': ['7080d799-e697-4c0e-bc2c-d69541f624fc'], 'spicy': ['e42ca4b0-06b5-4b29-94f4-d61a533dc86c']}).

Failed builds: 13/445, {'clib': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-880f2303-8bc5-4c4f-bf4d-a768d9a41411.txt', 'gdk-pixbuf': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-9c8fb278-4de1-45c8-90a6-00aaffc9cc65.txt', 'libtasn1': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-bdd4a736-80d8-48b9-abbc-434c49d69400.txt', 'libteken': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-52e9b273-f60a-4d0e-8bb2-63c878835d16.txt', 'mbedtls': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-d9337cec-3a34-4fa9-9b7d-dacdef32b102.txt', 'monero': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-c7ba969e-6cdb-4a96-b042-6cfc84146a45.txt', 'nss': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-d31a128e-455a-456b-8678-05cdddb8d286.txt', 'tinyusb': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-aad14904-2c9c-49e1-b2f6-e600f8c76929.txt', 'gnutls': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-94b3f849-1188-4882-9c95-94a668e0070e.txt', 'lua': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-ba06e4cb-78ca-4281-9368-8562de462f72.txt', 'inchi': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-b295ecd2-0143-4c45-b420-c1c08630ed24.txt', 'libucl': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-a4fcd4e7-50f7-4f21-8301-e38b381201e6.txt', 'netcdf': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-60b83191-1cc4-4087-b122-2f0aaac8f3e6.txt' }

@maflcko
Copy link
Contributor Author

maflcko commented May 8, 2024

Not sure about the failures. They are network related timeouts, or coverage/address sanitizer related. However, I only changed the cmake_libcxx function that builds msan and 32-bit libcxx. So those failures seem unrelated?

@maflcko
Copy link
Contributor Author

maflcko commented May 8, 2024

mbedtls is already failing, so the failure here is unrelated: https://oss-fuzz-build-logs.storage.googleapis.com/index.html#mbedtls

@maflcko
Copy link
Contributor Author

maflcko commented May 8, 2024

All other failures are also happening already, so this should be good to go?

@jonathanmetzman
Copy link
Contributor

/gcbrun trial_build.py clib gdk-pixbuf libtasn1 libteken mbedtls monero nss tinyusb gnutls lua inchi libucl netcdf python rust go swift --fuzzing-engines libfuzzer --sanitizers memory address coverage

@jonathanmetzman
Copy link
Contributor

Annoying that there's a False positive in trial builds due to ARM.

@jonathanmetzman jonathanmetzman merged commit e3ccec7 into google:master May 9, 2024
14 of 19 checks passed
@maflcko maflcko deleted the 2405-msan-pic branch May 13, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants