Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve .bat file conflict using direct command execution #18

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

hans-brgs
Copy link
Contributor

@hans-brgs hans-brgs commented Aug 9, 2023

Resolve .bat File Conflict by Direct Command Execution on Windows

This commit fixes the conflict encountered during the build process on Windows systems. The error was caused by multiple actions attempting to write to the same .bat file.

The solution implemented avoids this conflict by directly executing the necessary commands using cmd.exe, rather than writing to a shared .bat file. This allows actions to be executed independently without conflicting with one another, enabling a smooth build process.

The change includes:

  • Replacing the .bat file creation and execution with a direct command execution sequence in the _copy_action_windows function.
  • Adjusting the related parts of the code to align with the new command execution approach.

For further information, please consult this issue

@google-cla
Copy link

google-cla bot commented Aug 9, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@cmaf5 cmaf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cmaf5 cmaf5 merged commit e47f6a1 into google:main Sep 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants