Skip to content

Commit

Permalink
Remove saving matches and mismatches in Matching.save()
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 682343699
  • Loading branch information
yifenglou authored and langfun authors committed Oct 4, 2024
1 parent 5c8fa6a commit 0a2a548
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 17 deletions.
12 changes: 0 additions & 12 deletions langfun/core/eval/matching.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,18 +171,6 @@ def save(
) -> None:
super().save(definition, result, report)

if result:
# Save matches.
pg.save(
[
pg.symbolic.deref(
pg.Dict(input=input, output=output), recursive=True
)
for input, output, _ in self.matches
],
os.path.join(self.dir, Matching.MATCHES_JSON),
)

if report:
pg.save(
self._html([self._render_result, self._render_matches]),
Expand Down
5 changes: 0 additions & 5 deletions langfun/core/eval/matching_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,6 @@ def test_run(self):
os.path.join(s.dir, matching.Matching.CACHE_JSON)
)
)
self.assertTrue(
os.path.exists(
os.path.join(s.dir, matching.Matching.MATCHES_JSON)
)
)
self.assertTrue(
os.path.exists(
os.path.join(
Expand Down

0 comments on commit 0a2a548

Please sign in to comment.