Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JAX docs tutorial: How to think in JAX 101 #18581

Merged
merged 1 commit into from
Dec 13, 2023
Merged

JAX docs tutorial: How to think in JAX 101 #18581

merged 1 commit into from
Dec 13, 2023

Conversation

8bitmp3
Copy link
Contributor

@8bitmp3 8bitmp3 commented Nov 17, 2023 •
edited
Loading

@jakevdp jakevdp self-assigned this Nov 17, 2023
jakevdp
jakevdp reviewed Nov 17, 2023
View reviewed changes
docs/tutorials/thinking_in_jax.md Outdated Show resolved Hide resolved
docs/tutorials/thinking_in_jax.md Outdated Show resolved Hide resolved
@jakevdp jakevdp mentioned this pull request Nov 18, 2023
Open
25 tasks
@8bitmp3 8bitmp3 closed this Dec 1, 2023
@8bitmp3 8bitmp3 reopened this Dec 12, 2023
@8bitmp3 8bitmp3 requested a review from jakevdp December 12, 2023 21:25
@8bitmp3 8bitmp3 marked this pull request as ready for review December 12, 2023 21:25
@8bitmp3 8bitmp3 marked this pull request as draft December 12, 2023 22:36
@8bitmp3 8bitmp3 marked this pull request as ready for review December 12, 2023 23:19
@8bitmp3 8bitmp3 changed the title JAX docs tutorial: Thinking in JAX JAX docs tutorial: How to think in JAX 101 Dec 12, 2023
jakevdp
jakevdp approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think this will conflict with #18582 so let's plan to rebase once that's merged.

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Dec 13, 2023
@jakevdp
Copy link
Collaborator

jakevdp commented Dec 13, 2023

Please rebase against main and fix conflicts – thanks!

@jakevdp
Copy link
Collaborator

jakevdp commented Dec 13, 2023

Thanks! Please squash the commits into a single commit (FYI if you used git rebase main rather then git merge main initially, it would have done this from the start)

@8bitmp3 8bitmp3 closed this Dec 13, 2023
@8bitmp3 8bitmp3 reopened this Dec 13, 2023
copybara-service bot pushed a commit that referenced this pull request Dec 13, 2023
@yashk2810
[roll forward 2] Remove the `jax_require_devices_during_lowering flag…
a901f71 
… since it was temporary. Added the semi-breaking change to Changelog.md.

Reverts b52bcc1

FUTURE_COPYBARA_INTEGRATE_REVIEW=#18581 from 8bitmp3:jax-docs-thinking-in-jax a4003bf
PiperOrigin-RevId: 590701274
@copybara-service copybara-service bot mentioned this pull request Dec 13, 2023
Merged
@copybara-service copybara-service bot merged commit 29ed3cd into google:main Dec 13, 2023
18 of 19 checks passed
@8bitmp3 8bitmp3 deleted the jax-docs-thinking-in-jax branch December 13, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakevdp jakevdp jakevdp approved these changes

Assignees

@jakevdp jakevdp

Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@8bitmp3 @jakevdp @kokoro-team