Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate .editorconfig #500

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Conversation

lukyth
Copy link
Contributor

@lukyth lukyth commented May 5, 2020

resolve #445

I agree that having .editorconfig would be nice. Not sure how the config should look like for this project though.

@codecov-io
Copy link

Codecov Report

Merging #500 into master will decrease coverage by 0.04%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
- Coverage   96.32%   96.28%   -0.05%     
==========================================
  Files           6        6              
  Lines        1116     1130      +14     
  Branches      153      155       +2     
==========================================
+ Hits         1075     1088      +13     
- Misses         41       42       +1     
Impacted Files Coverage Δ
src/init.ts 88.26% <92.85%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb34f86...fa6b6dd. Read the comment docs.

Base automatically changed from master to main January 22, 2021 22:38
@bcoe bcoe merged commit 81397e0 into google:main Jun 7, 2022
@bcoe
Copy link
Contributor

bcoe commented Jun 7, 2022

@lukyth seems like a great feature to me, sorry for taking 2 years to review 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shipping .editorconfig
4 participants