Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust version numbers and a test to conform to the SemVer spec. #2237

Merged
merged 2 commits into from
Nov 13, 2022

Conversation

eamonnmcmanus
Copy link
Member

@eamonnmcmanus eamonnmcmanus commented Nov 13, 2022

Gson releases since 2.8.0 have been following this spec. We mistakenly released 2.10 without the .0 patch version, and adjusted GsonVersionDiagnosticsTest so it would accept that, as well as the two-digit 10. Here we make the test no longer accept versions without a patch number, while still accepting two-digit minor versions of course. We also change the snapshot version to 2.11.0-SNAPSHOT instead of 2.11-SNAPSHOT.

Gson releases since 2.8.0 have been following this spec. We mistakenly released 2.10
without the .0 patch version, and adjusted `GsonVersionDiagnosticsTest` so it would
accept that, as well as the two-digit `10`. Here we make the test no longer accept
versions without a patch number, while still accepting two-digit minor versions of course.
We also change the snapshot version to 2.10.1-SNAPSHOT instead of 2.11.
@eamonnmcmanus eamonnmcmanus merged commit 818faee into google:master Nov 13, 2022
@eamonnmcmanus eamonnmcmanus deleted the patch branch November 13, 2022 23:36
tibor-universe pushed a commit to getuniverse/gson that referenced this pull request Jan 20, 2023
…gle#2237)

* Adjust version numbers and a test to conform to the SemVer spec.

Gson releases since 2.8.0 have been following this spec. We mistakenly released 2.10
without the .0 patch version, and adjusted `GsonVersionDiagnosticsTest` so it would
accept that, as well as the two-digit `10`. Here we make the test no longer accept
versions without a patch number, while still accepting two-digit minor versions of course.
We also change the snapshot version to 2.11.0-SNAPSHOT instead of 2.11-SNAPSHOT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants