Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JsonTreeReader throwing wrong exception type for non-finite doubles #1782

Conversation

Marcono1234
Copy link
Collaborator

@Marcono1234 Marcono1234 commented Sep 13, 2020

Follow-up for #1767
Documentation for JsonReader is adjusted by #1723.

Either JsonReader or JsonTreeReader has to be adjusted because their behavior is currently inconsistent.

@google-cla google-cla bot added the cla: yes label Sep 13, 2020
@Marcono1234
Copy link
Collaborator Author

@eamonnmcmanus, could you please have a look?

@eamonnmcmanus eamonnmcmanus merged commit a4bc6c1 into google:master Aug 8, 2022
@Marcono1234 Marcono1234 deleted the marcono1234/JsonTreeReader-nan-infinity-exception-type branch August 8, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants