Add NotificationSetting to NewTeam (#3111)

Fixes: #3107.
google · Mar 25, 2024 · 8bec011 · 8bec011
1 parent b3e96fd
commit 8bec011
Show file tree

Hide file tree

Showing 5 changed files with 42 additions and 18 deletions.
diff --git a/github/github-accessors.go b/github/github-accessors.go
diff --git a/github/github-accessors_test.go b/github/github-accessors_test.go
diff --git a/github/github-stringify_test.go b/github/github-stringify_test.go
diff --git a/github/teams.go b/github/teams.go
@@ -155,6 +155,9 @@ type NewTeam struct {
 	RepoNames    []string `json:"repo_names,omitempty"`
 	ParentTeamID *int64   `json:"parent_team_id,omitempty"`
 
+	// NotificationSetting can be one of: "notifications_enabled", "notifications_disabled".
+	NotificationSetting *string `json:"notification_setting,omitempty"`
+
 	// Deprecated: Permission is deprecated when creating or editing a team in an org
 	// using the new GitHub permission model. It no longer identifies the
 	// permission a team has on its repos, but only specifies the default

diff --git a/github/teams_test.go b/github/teams_test.go
@@ -1590,14 +1590,15 @@ func TestNewTeam_Marshal(t *testing.T) {
 	testJSONMarshal(t, &NewTeam{}, "{}")
 
 	u := &NewTeam{
-		Name:         "n",
-		Description:  String("d"),
-		Maintainers:  []string{"m1", "m2"},
-		RepoNames:    []string{"repo1", "repo2"},
-		ParentTeamID: Int64(1),
-		Permission:   String("perm"),
-		Privacy:      String("p"),
-		LDAPDN:       String("l"),
+		Name:                "n",
+		Description:         String("d"),
+		Maintainers:         []string{"m1", "m2"},
+		RepoNames:           []string{"repo1", "repo2"},
+		NotificationSetting: String("notifications_enabled"),
+		ParentTeamID:        Int64(1),
+		Permission:          String("perm"),
+		Privacy:             String("p"),
+		LDAPDN:              String("l"),
 	}
 
 	want := `{
@@ -1606,6 +1607,7 @@ func TestNewTeam_Marshal(t *testing.T) {
 		"maintainers":    ["m1", "m2"],
 		"repo_names":     ["repo1", "repo2"],
 		"parent_team_id": 1,
+		"notification_setting": "notifications_enabled",
 		"permission":     "perm",
 		"privacy":        "p",
 		"ldap_dn":        "l"