Refactor clasp push

[campionfellin]

Pulled clasp push out and refactored its internal functions a bit.

Signed-off-by: campionfellin campionfellin@gmail.com

Works on #501

• npm run test succeeds.
• npm run lint succeeds.
• Appropriate changes to README are included in PR.

[campionfellin]

We also get a lot more granular info on code coverage by separating out each command

[grant]

Cool!
I'll let @erickoledadevrel review the PR.

---

Can we figure out how to use absolute import paths rather than relative (tsconfig?)?

} from '/commands/auth'
// Rather than
} from './../auth'

[campionfellin]

I looked into using absolute paths, but it doesn't look feasible at this time.

We could use absolute path mappings:

    "baseUrl": ".",
    "paths": {
      "*": ["*"],
      "src/auth": ["src/auth"],
      "commands/*": ["commands/*"],
    },
  },
  "moduleResolution": "node",

as suggested by TS documentation (see https://www.typescriptlang.org/docs/handbook/module-resolution.html).

However, take a look here at the clone.js compiled code:

var _this = this;
Object.defineProperty(exports, "__esModule", { value: true });
var auth_1 = require("src/auth");
var urls_1 = require("src/urls");
var utils_1 = require("src/utils");
var files_1 = require("src/files");

This actually now tries to resolve the modules in the node_modules directory.

There's a bunch of discussion here about the issue microsoft/TypeScript#10866

We could use a 3rd party library, but I'd prefer not to.

[campionfellin]

@erickoledadevrel have you had a chance to give this a look? Thanks!

[erickoledadevrel]

Sorry for the delay!

[erickoledadevrel]

Nitpick: Should this be collapsed into one line, since there is only one import happening?

[campionfellin]

It could be. I figured to keep it multi-line to stay with the style of the other imports. I can change to one-line.

[erickoledadevrel]

Given all the imports added to this new file, are there now any unused imports in commands.ts? I can't tell just by looking at this PR, but feels like there is a good chance that at least a few of these imports aren't needed by the remaining code.

[campionfellin]

There are many unused imports in commands.ts (unrelated).

The only one that was moved over from commands.ts to push.ts that is now unused in commands.ts is PROJECT_MANIFEST_FILENAME from utils. I can remove it.

[erickoledadevrel]

Was there any changes made to the actual code, or was it just copied and pasted as-is? Hard to tell with the diff view.

[campionfellin]

Yes, great question.

The constants manifestHasChanges and confirmManifestUpdate were extracted to the bottom of the file and comments were added to them.

My thought is that it improves code readability. Additionally, if we wanted in the future, we could export these and test them individually.

[erickoledadevrel]

Looks good!