Support assignment of a wrapper field to null #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristonianJones
requested review from
l46kok and
jnthntatum
and removed request for
l46kok
… 'null' value indicates the wrapper will remain unset.
TristonianJones
force-pushed
the
wrapper-to-null-fix
branch
from
7170f22
to
9afd30d
Compare
jnthntatum
approved these changes
Nov 4, 2022
l46kok
approved these changes
Nov 4, 2022
|
@l46kok agreed. I think there are probably more proto-based tests which should cover edge cases like this one. |
TristonianJones
added a commit
to TristonianJones/cel-go
that referenced
this pull request
Nov 8, 2022
* Support for runtime assignment of 'null' to a wrapper field where the 'null' value indicates the wrapper will remain unset. * Additional test for roundtripping unset wrappers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a protobuf wrapper type field is assigned to null, the wrapper field should
be unset in the containing proto message as
nullindicates that the field was unsetto begin with. Thus, the following expression should roundtrip: