Refinement on recursion depth checking #585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change unnests common object graphs which resolve to simple expressions, and reduces the number of stack frames needed to build an AST from the parse graph. This change is believed to be safe as it expands the number of expressions which will pass max recursion depth test.
Additionally, all rules which may left recurse are only tracked if they contain a recursive parse graph thanks to the unnesting step.