Bump Bazel on Travis to 0.17.1 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack overflow users claim that failures on the left hand side of a boolean operator don't properly trigger the Since master currently fails, I can test the fix and merge this PR into my branch in once this PR is in master |
Merged
|
Looks like you're falling prey to bazelbuild/rules_rust#133 (comment) Adding that to the smoketest workspace should suffice. |
|
Thanks for making this followup PR to update rules_rust and add that missing dependency! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.17 is the minimum version supported by rules_rust at this point.
Still unclear why Bazel build failures didn't cause a Travis failure (https://travis-ci.org/google/cargo-raze/builds/477524733). Maybe 0.11 doesn't return a bad exit code during loading phase failures?