Fix uint64 overflow in info/v2/conversion.go. #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
@k8s-bot test this |
|
LGTM |
Random-Liu
force-pushed
the
fix-data-overflow
branch
from
9a728b3
to
8c362dc
Compare
|
@dchen1107 Just did a rebase just now. The code base is changing so fast~ :) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For kubernetes/kubernetes#27194.
The current implementation of
InstCpuStatswill sometimes cause data overflow. (See detail)Without this change, when
valueDeltais18949414524,timeDeltaNsis17978530662, it will return27959484, with this change it will return1054002403correctly.I also removed the dead code
instCpuStats.@dchen1107
/cc @timstclair @vishh