Godeps: revendor packags with more up-to-date godep version #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
ericchiang
force-pushed
the
cleanup_godeps
branch
from
90ebe54
to
75ef2ec
Compare
|
ok to test |
|
What's a good way to add |
ericchiang
force-pushed
the
cleanup_godeps
branch
from
75ef2ec
to
10166c1
Compare
|
What version of godeps was used? |
Should we record this somewhere? |
|
Yeah. Given that godep is not compatible across versions, we should document it. |
|
This PR LGTM. Merging it.. |
vishh
added a commit
that referenced
this pull request
Mar 15, 2016
Godeps: revendor packags with more up-to-date godep version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1161