Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove uses of the multiline block or field in other plugins #2239

Conversation

rachel-fenichel
Copy link
Collaborator

The basics

The details

Resolves

Part of #2194

Proposed Changes

Delete uses of the multiline field or related block in other plugins and examples.

Reason for Changes

These are no longer provided as part of core, so we would need to depend on the field-multilineinput plugin to include them in tests and demos. They are not being used actively in tests, so I prefer to delete them.

@rachel-fenichel rachel-fenichel requested a review from a team as a code owner March 13, 2024 22:16
@rachel-fenichel rachel-fenichel requested review from NeilFraser and removed request for a team March 13, 2024 22:16
@rachel-fenichel rachel-fenichel merged commit 9e1688d into google:blocks_for_fields Mar 20, 2024
11 checks passed
@rachel-fenichel rachel-fenichel deleted the remove_multiline_references branch March 20, 2024 14:59
rachel-fenichel added a commit to rachel-fenichel/blockly-samples that referenced this pull request Apr 2, 2024
rachel-fenichel added a commit that referenced this pull request Apr 2, 2024
* fix: remove references to colour fields and blocks (#2241)

* chore: delete uses of colour blocks from most other plugins

* chore: delete colour blocks from shadow block converter

* chore: stop using colour fields in block-test plugin

* fix: param order

* chore: remove uses of the multiline block or field in other plugins (#2239)
gonfunko pushed a commit to gonfunko/blockly-samples that referenced this pull request Apr 15, 2024
* fix: remove references to colour fields and blocks (google#2241)

* chore: delete uses of colour blocks from most other plugins

* chore: delete colour blocks from shadow block converter

* chore: stop using colour fields in block-test plugin

* fix: param order

* chore: remove uses of the multiline block or field in other plugins (google#2239)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants