Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup after deleting blocks and fields from core #2194

Closed
1 task done
rachel-fenichel opened this issue Feb 6, 2024 · 3 comments · Fixed by #2454
Closed
1 task done

Cleanup after deleting blocks and fields from core #2194

rachel-fenichel opened this issue Feb 6, 2024 · 3 comments · Fixed by #2454
Assignees

Comments

@rachel-fenichel
Copy link
Collaborator

Check for duplicates

  • I have searched for similar issues before opening a new one.

Component

Angle, colour, and multiline input fields.

Description

After #2162 there will be multiple pieces of code in field plugins that compensate for the blocks and fields already being installed as part of the core library. Once the fields are removed form core (google/blockly#7226), the plugins will need to be updated.

Examples include

  • In test pages, deleting blocks and generators for blocks provided by the plugin.
  • In field registration functions, unregistering existing fields before registering the new ones.

Reproduction steps

No response

Stack trace

No response

Screenshots

No response

@rachel-fenichel rachel-fenichel self-assigned this Feb 6, 2024
@BeksOmega
Copy link
Contributor

Is this release blocking? If so, might be good to bump the priority. I think we might not get to some of the P1s this Q, and I don't want this to get lost.

@rachel-fenichel
Copy link
Collaborator Author

No, this isn't release blocking. These are only changes in samples, and the existing code will not break when the fields are deleted from core--it'll just be useless clutter.

@rachel-fenichel
Copy link
Collaborator Author

To find the remaining work, search for TODO(2194) in the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants