fix: update dependencies of blockly-rtc so it builds #1092
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1087
Previously,
npm install
failed for most due to errors about having python installed. I expect for most of the team that happened because we were all forced to update macOS versions which removed python2. We were previously using an old version of sqlite that needed python2.@vscode/sqlite3
which is just a more recently updated version of the package. Seems like the original package is not being updated on npm anymore. We needed a more recent version so that the node-gyp version wouldn't be hardcoded to v3.node-gyp
v9. Under the hood installing sqlite involves using node-gyp, and if you have it in the devDependencies it will use the version you specify. You need v9 for it to correctly handle the nuances of python on mac.Note that if you are still having problems on mac and you get an error about not having Xcode dependencies installed, you need to install the Xcode command line tools. See also this doc if you are having problems: https://github.com/nodejs/node-gyp/blob/master/macOS_Catalina.md
Tested: