Skip to content

Commit

Permalink
Update lion_pytorch.py
Browse files Browse the repository at this point in the history
This function already does summation in place, and therefore errors out when the inplace parameters is passed into the _add func.
  • Loading branch information
ki-arie committed Nov 21, 2023
1 parent c7392f2 commit e84b5e0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lion/lion_pytorch.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def step(self, closure=None):
# Weight update
update = exp_avg * beta1 + grad * (1 - beta1)

p.add_(torch.sign(update), alpha=-group['lr'], inplace=True)
p.add_(torch.sign(update), alpha=-group['lr'])
#This has been made more efficient by using the torch.sign function's inplace mode.
#This will prevent the need to create a new tensor for the updated parameter,
#which can save a significant amount of time for large models.
Expand Down

0 comments on commit e84b5e0

Please sign in to comment.