add sample_idx in InputRequest for debugging #32
Conversation
morgandu
force-pushed
the
mor--add-request-id
branch
6 times, most recently
from
f8ad178
to
d283ee8
Compare
morgandu
force-pushed
the
mor--add-request-id
branch
from
d283ee8
to
741d9e7
Compare
morgandu
changed the title
|
|
||
| tokenized_dataset = tokenize_dataset(dataset, tokenizer) | ||
| sampled_dataset = [] |
There was a problem hiding this comment.
Just curious, numpy has numpy.take?
| @@ -98,6 +98,7 @@ class InputRequest: | |||
| prompt_len: int = 0 | |||
| output: str = "" | |||
| output_len: int = 0 | |||
| sample_idx: int = -1 | |||
There was a problem hiding this comment.
There is right mapping between request and output in benchmark. what is the purpose of sample_idx? Will it help you find the related request easily?
There was a problem hiding this comment.
+1, your goal is to be able to print the input prompt for the output for debugging right?
There was a problem hiding this comment.
My goal is to be able to locate the original order / index from the original dataset file.
Say, if there are 10k data samples in the original dataset file, after randomly sampling, being passed as input request into server, the requests are returned based on decode completions. Currently we save the prompt, original result, and generated result in the request output file. If there are other metadata I am interested in checking in the original dataset file. How can I locate them?
There was a problem hiding this comment.
agree, it's hard to locate original dateset. Please also feel free to add the important metadata into the result.
No description provided.