Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plumb MediaCodecRenderer.enableDecoderFallback through DefaultRenderersFactory #5942

Closed
ojw28 opened this issue May 24, 2019 · 1 comment
Closed

Plumb MediaCodecRenderer.enableDecoderFallback through DefaultRenderersFactory #5942

ojw28 opened this issue May 24, 2019 · 1 comment
Assignees
@andrewlewis
Labels
enhancement

Comments

@ojw28
Copy link
Contributor

ojw28 commented May 24, 2019

[REQUIRED] Use case description

Enable decoder fallback without having to subclass DefaultRenderersFactory, as requested
here.

@andrewlewis - Is there a reason we didn't expose the possibility of fallback for the audio renderer as well?
@google google deleted a comment from google-oss-bot May 24, 2019
ojw28 referenced this issue May 24, 2019
@andrewlewis @ojw28
Signal fallback via renderer constructor
401e20d 
Remove MediaCodecSelector.DEFAULT_WITH_FALLBACK, as codec selectors
will need to be able to return a list of decoder infos even when not
using fallback in a later change. Instead signal that fallback should
be used via a renderer constructor.

Fallback is always disabled for audio.

PiperOrigin-RevId: 242454172
@andrewlewis
Copy link
Collaborator

As discussed I don't think there's a reason not to expose fallback for audio (I was going on the assumption that audio decoders are generally not hardware-accelerated so are much less likely to fail to initialize transiently). I will do that as part of this enhancement.

tonihei pushed a commit that referenced this issue May 30, 2019
@andrewlewis @tonihei
Allow enabling decoder fallback in DefaultRenderersFactory
90325c6 
Also allow enabling decoder fallback with MediaCodecAudioRenderer.

Issue: #5942
PiperOrigin-RevId: 250301422
@ojw28 ojw28 closed this as completed May 31, 2019
ojw28 pushed a commit that referenced this issue Jun 3, 2019
@andrewlewis @ojw28
Allow enabling decoder fallback in DefaultRenderersFactory
8bc14bc 
Also allow enabling decoder fallback with MediaCodecAudioRenderer.

Issue: #5942
PiperOrigin-RevId: 250301422
@google google locked and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andrewlewis andrewlewis

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewlewis @ojw28