Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some videos getting distorted... #4348

Closed
selimonline opened this issue Jun 6, 2018 · 4 comments
Closed

Some videos getting distorted... #4348

selimonline opened this issue Jun 6, 2018 · 4 comments
Assignees
Labels

Comments

@selimonline
Copy link

selimonline commented Jun 6, 2018

Problems :

few videos getting distorted at certain position
here is screenshot.....
https://image.prntscr.com/image/sp6cF6eXQQKwy21J9XkckA.png

Build.gradle

implementation 'com.google.android.exoplayer:exoplayer-core:2.7.0'
implementation 'com.google.android.exoplayer:exoplayer-ui:2.7.0'

(although I tried most latest versions). same issues always...

Activity code :

BandwidthMeter bandwidthMeter = new DefaultBandwidthMeter();
        TrackSelector trackSelector = new DefaultTrackSelector(new AdaptiveTrackSelection.Factory(bandwidthMeter));
        player = ExoPlayerFactory.newSimpleInstance(view.getContext(), trackSelector);


        Uri videoUri = Uri.parse("HTTPS SRC PATH");
        PlayerView video_view = (PlayerView) view.findViewById(R.id.video_view);

        DefaultDataSourceFactory dataSourceFactory = new DefaultDataSourceFactory(this, Util.getUserAgent(this, "oevo"));
        MediaSource videoSource = new ExtractorMediaSource(videoUri,dataSourceFactory, new DefaultExtractorsFactory(), null, null);

player.setPlayWhenReady(true); player.prepare(videoSource);

Testing Device :
Samsung edge s7

Video Url :
https://oevo.com/exo/TFWsBEnXMgqncUxRxMmGlPAjALAWsqsM.mp4

any idea highly appreciated. Thanks

@ojw28 ojw28 assigned andrewlewis and unassigned ojw28 Jun 19, 2018
@ojw28
Copy link
Contributor

ojw28 commented Jun 19, 2018

This appears to be edit list related. I suspect the video falls under the

Edit lists that require prerolling from a sync sample after reordering are not supported

case in AtomParsers. What do we actually do in this case? Should we ignore the edit list, rather than doing whatever we're currently doing? Whatever we're currently doing appears to be what introduces the distortion.

@ojw28 ojw28 added the bug label Jun 19, 2018
@andrewlewis
Copy link
Collaborator

Ignoring edit lists for all tracks in this situation is probably preferable to the current behavior for most apps.

Until that is implemented, I suggest setting DefaultExtractorsFactory.setMp4ExtractorFlags(FLAG_WORKAROUND_IGNORE_EDIT_LISTS) on the extractors factory to ignore all edit lists. We are unlikely to implement support for prerolling media for edit lists any time soon.

ojw28 pushed a commit that referenced this issue Jul 12, 2018
Issue: #4348

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=204261718
@ojw28
Copy link
Contributor

ojw28 commented Jul 17, 2018

Fixed in dev-v2.

@ojw28 ojw28 closed this as completed Jul 17, 2018
ojw28 pushed a commit that referenced this issue Jul 23, 2018
Issue: #4348

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=204261718
ojw28 pushed a commit that referenced this issue Sep 12, 2018
…keyframe.

Ignoring all edit lists if they don't start with a keyframe causes A/V sync
issues when valid edit lists are applied at the beginning.

This change allows such edit lists again but removes all samples before the
first keyframe (these samples would be ignored by the renderer anyway if at
the beginning OR cause visible distortions when appended to an unrelated
keyframe).

Issue:#4774
Issue:#4348

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=212244407
@selimonline
Copy link
Author

Thanks everyone, It seems you have fixed all these issues on version 2.8.4. If still anyone having same issues, make sure you are using version 2.8.4. Exo is best for android 👍

Thanks again bro @ojw28

@google google locked and limited conversation to collaborators Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants