Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for container format sniffing in HLS #2025

Closed
jschm1 opened this issue Nov 1, 2016 · 3 comments
Closed

Add support for container format sniffing in HLS #2025

jschm1 opened this issue Nov 1, 2016 · 3 comments
Assignees

Comments

@jschm1
Copy link

jschm1 commented Nov 1, 2016

For the HLS stream below, ExoPlayer fails to display subtitles:

http://drod05p-vh.akamaihd.net/i/all/clear/download/bd/58049ebc6187a40d7cea30bd/Hammerslag--1-10-_5d30d8de7cab45628de5820ac0d965cc_,309,502,956,2059,2880,.mp4.csmil/master.m3u8?cc1=name=Dansk~default=yes~forced=no~lang=da~uri=https://www.dr.dk/mu/subtitles/playlist/urn:dr:mu:manifest:58049ebc6187a40d7cea30bd?segmentsizeinms=60000%26subtitleType=HardOfHearing

When played in Safari on Mac OS, subtitles are displayed correctly for this stream.

ExoPlayer seems to recognize the available subtiles and lists them in the subtitle-selection-dialog displayed when clicking the "Text" button. However, selecting the subtiles "da, id:Dansk" and clicking "OK" does not activate the subtitles. No errors are printed in logcat.

ExoPlayer version: DemoPlayer 2.0.4
Devices tested: HTC One m9 & HTC 10
Reproducible every time.

@jschm1 jschm1 changed the title ExoPlayer 2.0.4 is unable to play HLS subtiles for particular m3u file ExoPlayer 2.0.4 is unable to play HLS subtitles for particular m3u file Nov 1, 2016
@jschm1 jschm1 changed the title ExoPlayer 2.0.4 is unable to play HLS subtitles for particular m3u file ExoPlayer 2.0.4 is unable to play HLS WebVVT subtitles for particular m3u file Nov 1, 2016
@AquilesCanta
Copy link
Contributor

The reason behind this bug is that the vtt segments don't have a .vtt/.webvtt extension. This means that the stream does not get past preparing state for V1.

I couldn't find any constrains over the extension of the segment URIs in the spec so this is an actual bug. For the time being, if you can rename the webvtt segments so that they end with .vtt, that will fix the issue for you.

@jschm1 jschm1 changed the title ExoPlayer 2.0.4 is unable to play HLS WebVVT subtitles for particular m3u file ExoPlayer 2.0.4 is unable to play HLS WebVTT subtitles for particular m3u file Nov 2, 2016
@jschm1
Copy link
Author

jschm1 commented Nov 2, 2016

Thanks for quick response.
Adding a .vtt extension seemed to do the trick.

@AquilesCanta AquilesCanta changed the title ExoPlayer 2.0.4 is unable to play HLS WebVTT subtitles for particular m3u file ExoPlayer determines container format through file extension in HLS Dec 1, 2016
ojw28 pushed a commit that referenced this issue Jan 24, 2017
According to the spec, subtitle renditions must be Webvtt media
segments.

Issue:#2025
Issue:#2355

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=145289266
ojw28 pushed a commit that referenced this issue Jun 18, 2018
@AquilesCanta AquilesCanta changed the title ExoPlayer determines container format through file extension in HLS Add support for container format sniffing in HLS Sep 3, 2018
ojw28 pushed a commit that referenced this issue Sep 12, 2018
Issue:#2025

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=211977802
@ojw28
Copy link
Contributor

ojw28 commented Sep 12, 2018

Support has been added to 2.9.0.

@ojw28 ojw28 closed this as completed Sep 12, 2018
@google google locked and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants