Skip to content

Commit

Permalink
fix wrong use of @overrides.overrides to @overrides.override.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 650024515
Change-Id: Ie2833d42bfca9db4cb15c5df9dc1e08afcec38cb
  • Loading branch information
duenez authored and copybara-github committed Jul 7, 2024
1 parent 1dc30f3 commit 2857194
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions concordia/agents/entity_agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def __init__(
component.set_entity(self)

@functools.cached_property
@overrides.overrides
@overrides.override
def name(self) -> str:
return self._agent_name

Expand Down Expand Up @@ -115,7 +115,7 @@ def _parallel_call_(
name: future.result() for name, future in context_futures.items()
}

@overrides.overrides
@overrides.override
def act(self,
action_spec: entity.ActionSpec = entity.DEFAULT_ACTION_SPEC) -> str:
self._phase = component_v2.Phase.PRE_ACT
Expand All @@ -133,7 +133,7 @@ def act(self,

return action_attempt

@overrides.overrides
@overrides.override
def observe(
self,
observation: str,
Expand Down
2 changes: 1 addition & 1 deletion concordia/components/agent/v2/all_similar_memories.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def get_last_log(self):
if self._history:
return self._history[-1].copy()

@overrides.overrides
@overrides.override
def make_pre_act_context(self) -> str:
agent_name = self.get_entity().name
prompt = interactive_document.InteractiveDocument(self._model)
Expand Down
2 changes: 1 addition & 1 deletion concordia/components/agent/v2/observation.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def pre_observe(
)
return ''

@overrides.overrides
@overrides.override
def make_pre_act_context(self) -> str:
mems = self._memory.retrieve_time_interval(
self._clock_now() - self._timeframe, self._clock_now(), add_time=True
Expand Down
4 changes: 2 additions & 2 deletions concordia/memory_bank/legacy_associative_memory.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,15 +90,15 @@ class AssociativeMemoryBank(memory_lib.MemoryBank):
def __init__(self, memory: associative_memory.AssociativeMemory):
self._memory = memory

@overrides.overrides
@overrides.override
def add(self, text: str, metadata: Mapping[str, Any]) -> None:
self._memory.add(text, **metadata)

def _texts_with_constant_score(
self, texts: Sequence[str]) -> Sequence[tuple[str, float]]:
return [(t, 0.0) for t in texts]

@overrides.overrides
@overrides.override
def retrieve(
self,
query: str,
Expand Down

0 comments on commit 2857194

Please sign in to comment.