Adding huggingface generators for clrs text #135
+264
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grenlayk
suggested changes
Jun 26, 2024
Co-authored-by: Olga Kozlova <grenlaykk@gmail.com>
… instead of exactly equal sampling. Added a use_hints field so data with and without hints can be identified per sample.
grenlayk
suggested changes
Jun 28, 2024
There was a problem hiding this comment.
Thank you for such a fast response!
I realized that I forgot to mention one significant point during the last iteration: we don't really need 2 separate generator functions, because they are almost identical, we can simply utilize different values for num_samples argument (i.e. set it to None or integer value).
Regarding the tests, I propose that I modify them myself and ask you to review them. Let me know what you think about it.
RerRayne
reviewed
Jun 28, 2024
|
Jfyi I will add the test file tomorrow in the morning and ask both of you for the final review. Thanks! |
grenlayk
approved these changes
Jul 4, 2024
|
"Pull request authors can’t approve their own pull request." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Huggingface Datasets
.from_generatorsupport to allow for CLRS-Text datasets to be easily converted to huggingface format.