NamespacePath: a message compatible "object reference" type
#295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.9's new object resolver + a `str` is much simpler then mucking with tuples (and easier to serialize). Include a `.to_tuple()` formatter since we still are passing the module namespace and function name separately inside the runtime's message format but in theory we might be able to simplify this depending on how we would change the support for `enable_modules:list[str]` in the spawn API. Thanks to @Fuyukai for pointing `resolve_name()` which I didn't know about before!
guilledk
approved these changes
Jan 30, 2022
goodboy
commented
Jan 30, 2022
|
|
||
| class NamespacePath(str): | ||
| ''' | ||
| A serializeable description of a (function) Python object location |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion in #294 and looking for scrutiny and feedback on how this might play well with our
ActorNursery.start_actor(<name>, enable_modules:list[str])module capability system.