fix out-of-bounds read

gomarkdown · Sep 22, 2023 · 14b1601 · 14b1601
1 parent 7478c23
commit 14b1601
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/parser/block.go b/parser/block.go
@@ -191,6 +191,11 @@ func (p *Parser) Block(data []byte) {
 		// <div>
 		//     ...
 		// </div>
+
+		if len(data) == 0 {
+			continue
+		}
+
 		if data[0] == '<' {
 			if i := p.html(data, true); i > 0 {
 				data = data[i:]
@@ -393,7 +398,7 @@ func (p *Parser) AddBlock(n ast.Node) ast.Node {
 }
 
 func (p *Parser) isPrefixHeading(data []byte) bool {
-	if data[0] != '#' {
+	if len(data) > 0 && data[0] != '#' {
 		return false
 	}
 

diff --git a/parser/citation.go b/parser/citation.go
@@ -65,6 +65,11 @@ func citation(p *Parser, data []byte, offset int) (int, ast.Node) {
 		}
 
 		citeType := ast.CitationTypeInformative
+
+		if len(citation) < 2 {
+			continue
+		}
+
 		j = 1
 		switch citation[j] {
 		case '!':