Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug gci commit #3683

Closed
wants to merge 1 commit into from
Closed

debug gci commit #3683

wants to merge 1 commit into from

Conversation

daixiang0
Copy link
Contributor

@daixiang0 daixiang0 commented Mar 13, 2023 •
edited
Loading

Debug #3674 since no MAC or WIN machine.

@alexandear
Copy link
Member

I have macOS and Windows machines, so can test this bump.

@daixiang0
Copy link
Contributor Author

@alexandear thank you very much, now we can confirm c19c1aa5634e bring this panic.

@daixiang0 daixiang0 changed the title test gci commit debug gci commit Mar 13, 2023
@daixiang0
Copy link
Contributor Author

Run codes with online playground and find root cause, daixiang0/gci#151 fix this.

@ldez
Copy link
Member

ldez commented Mar 13, 2023 •
edited
Loading

you can use your own fork to test it.

@daixiang0 daixiang0 closed this Mar 13, 2023
@ldez ldez closed this Mar 13, 2023
@ldez ldez added the declined label Mar 13, 2023
@daixiang0
test gci commit
534d24f 
Signed-off-by: Loong <loong.dai@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
declined
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daixiang0 @alexandear @ldez