x/vuln/cmd/govulncheck: outdated go version requirements in doc.go

[iglov]

Go version

go version go1.19.13 linux/amd64

Output of go env in your module/workspace:

GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.19.13"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3395868057=/tmp/go-build -gno-record-gcc-switches"

What did you do?

docker run --rm -it golang:1.19 bash
go install golang.org/x/vuln/cmd/govulncheck@v1.1.2

What did you see happen?

go: downloading golang.org/x/vuln v1.1.2
go: downloading golang.org/x/telemetry v0.0.0-20240522233618-39ace7a40ae7
go: downloading golang.org/x/tools v0.22.0
go: downloading golang.org/x/mod v0.18.0
go: downloading golang.org/x/sync v0.7.0
pkg/mod/golang.org/x/vuln@v1.1.2/internal/openvex/handler.go:12:2: package slices is not in GOROOT (/usr/local/go/src/slices)

I think it should be installed, as on go1.21 (docker image golang:1.21) - it works fine there. It should be supported from 1.18 as it said here https://pkg.go.dev/golang.org/x/vuln@v1.1.2/cmd/govulncheck
I think it cuz of that: https://go.googlesource.com/vuln/+/f35edf848bf0f2b9cf411833c60f72cc49915487
Soo-o-o, it looks like we should fix documentation...

What did you expect to see?

installed package OR fixed documentation with requirements go >=1.21 :)

[gabyhelp]

Related Issues

• x/vuln: package slices is not in GOROOT #68034 (closed)
• x/vuln: Cannot install govulncheck anymore since yesterday #57189 (closed)
• x/tools/gopls: broken build with x/vuln@latest #59837 (closed)
• x/vuln/cmd/govulncheck: incorrect error message #57013 (closed)
• x/vuln: Binary mode not compatible with golang 1.21.0 #61936 (closed)
• x/vuln: govulncheck is confused when go command version doesn't match that used to build it #55045 (closed)
• x/vuln: Does not use the correct GOPATH: Index(): mkdir /pkg: permission denied #57406 (closed)
• x/vulndb: build is broken #46088 (closed)
• x/vuln: govulncheck reports no vulnerabilities while deps.dev reports two vulns #54970 (closed)
• cmd/go: install -mod=readonly pkg uses -lang=go1.16 #58388 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/595935 mentions this issue: cmd/govulncheck: remove line about go version requirements

[thanm]

@golang/vulndb