Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: build is broken #46088

Closed
heschi opened this issue May 10, 2021 · 1 comment
Closed

x/vulndb: build is broken #46088

heschi opened this issue May 10, 2021 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone

Comments

@heschi
Copy link
Contributor

heschi commented May 10, 2021

The repository appears to have been broken since its addition to the trybots. There is an outstanding change that claims to fix it, https://golang.org/cl/314669.

linux-amd64 at d9e068d2894ff2fce48a171212171bc3f394b023 building vulndb at e0c00fae09e687ec6febda47ae3bc7552fc7b988

testing in module mode; GOMOD=/workdir/gopath/src/golang.org/x/vulndb/go.mod

:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/vulndb/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rnd679047" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=100ms" "GO_STAGE0_DL_DELAY=100ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.58:30157" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/vulndb

go: downloading gopkg.in/yaml.v2 v2.4.0
go: downloading golang.org/x/mod v0.4.1
go: downloading github.com/google/go-cmp v0.5.4
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
# golang.org/x/vulndb/osv [golang.org/x/vulndb/osv.test]
osv/json_test.go:18:3: cannot use []struct { Module string; Package string; Symbols []string; Versions []report.VersionRange }{...} (type []struct { Module string; Package string; Symbols []string; Versions []report.VersionRange }) as type []struct { Module string "yaml:\",omitempty\""; Package string "yaml:\",omitempty\""; Symbols []string "yaml:\",omitempty\""; Versions []report.VersionRange "yaml:\",omitempty\"" } in field value
osv/json_test.go:46:3: cannot use struct { PR string; Commit string; Context []string }{...} (type struct { PR string; Commit string; Context []string }) as type struct { PR string "yaml:\",omitempty\""; Commit string "yaml:\",omitempty\""; Context []string "yaml:\",omitempty\"" } in field value
ok  	golang.org/x/vulndb/client	0.015s
?   	golang.org/x/vulndb/cmd/gendb	[no test files]
?   	golang.org/x/vulndb/cmd/genhtml	[no test files]
?   	golang.org/x/vulndb/cmd/linter	[no test files]
?   	golang.org/x/vulndb/cmd/report2cve	[no test files]
FAIL	golang.org/x/vulndb/osv [build failed]
?   	golang.org/x/vulndb/report	[no test files]
FAIL

@FiloSottile @empijei

@heschi heschi added NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels May 10, 2021
@heschi heschi added this to the Unreleased milestone May 10, 2021
@bcmills
Copy link
Contributor

bcmills commented May 27, 2021

Looks like the build itself is fixed, but TestClient is consistently failing; filed as #46419.

@bcmills bcmills closed this as completed May 27, 2021
@golang golang locked and limited conversation to collaborators May 27, 2022
@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
Status: No status
Development

No branches or pull requests

4 participants