Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/telemetry/upload: UploadConfig is sticky #62405

Closed
hyangah opened this issue Aug 31, 2023 · 2 comments
Closed

x/telemetry/upload: UploadConfig is sticky #62405

hyangah opened this issue Aug 31, 2023 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Aug 31, 2023

We originally thought upload would run from a separate process,
and made it to download the UploadConfig only once and keep using it.
(code)

But we ended up calling upload from a goroutine periodically in gopls integration.
This caused a long running gopls instance to keep using the same (or maybe stale) version of config throughout its lifetime.

cc @pjweinb @findleyr

@gopherbot gopherbot added the telemetry x/telemetry issues label Aug 31, 2023
@gopherbot gopherbot added this to the Unreleased milestone Aug 31, 2023
@pjweinb
Copy link

pjweinb commented Aug 31, 2023 via email

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 31, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/524819 mentions this issue: gopls/internal/telemetry: don't schedule the next upload

@golang golang locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Projects
None yet
Development

No branches or pull requests

4 participants