Simplify temp dir creation in tests #882
Conversation
If the tempdir is evaluated on creation, there is no need for special handling of "darwin" (OSX) in NewTestProject()
|
Note, this PR don't solve any bug in the dep tool. It just makes the testing code simpler, and it makes the OSX build on travis simpler to handle. At the moment both the GOPATH and the project paths on OSX are symlinks. Any change trying to eval only one of those symlinks (either the GOPATH or the project path) will cause to fourth (OSX) build to fail. See, for example the build for #834: https://travis-ci.org/golang/dep/builds/254211644?utm_source=github_status&utm_medium=notification Same to the first build in #812 |
|
|
||
| // Fox for OSX where the tempdir is a symlink: | ||
| p.tempdir, err = filepath.EvalSymlinks(p.tempdir) | ||
| p.Must(err) |
There was a problem hiding this comment.
Why not wrap this in if runtime.GOOS == "darwin" { ... }?
There was a problem hiding this comment.
...for a hypothetical new OS/platform which also creates temp files as symlinks? :)
PS. Added now.
|
thanks! 🎉 |
If the tempdir is evaluated on creation, there is no need for special
handling of "darwin" (OSX) in NewTestProject()
What does this do / why do we need it?
It simplifies the code in
NewTestProject()(internal/test/integration_testproj.go) by removing special handling whenruntime.GOOS == "darwin".The problem is that tempfiles[1] on OSX are symlinks and it's just simpler to EvalSymlinks when the test directory is created than having special handling for
"darwin"later.[1] An example temp directory on OSX: