Back out "Update Yoga.podspec: fixes archiving for macos catalyst on …

…react-native 0.73.1 in xcode"

Summary:
PR facebook#42159 was working but it was the wrong fix.

The right fix is to use the `"PUBLIC_HEADERS_FOLDER_PATH"` Xcode build setting instead.

bypass-github-export-checks

## Changelog:
[iOS][Changed] - Revert "Update Yoga.podspec: fixes archiving for macos catalyst on react-native 0.73.1 in xcode"

## Facebook:
Original commit changeset: 21b9b3568986

Original Phabricator Diff: D52624342

Reviewed By: arushikesarwani94

Differential Revision: D52656133

fbshipit-source-id: 84a37fe3fca57d5e34139c17c6c1957fe8d40aaf

packages/react-native/ReactCommon/yoga/Yoga.podspec

@@ -31,8 +31,7 @@ Pod::Spec.new do |spec|
   spec.header_dir = 'yoga'
   spec.requires_arc = false
   spec.pod_target_xcconfig = {
-      'DEFINES_MODULE' => 'YES',
-      'HEADER_SEARCH_PATHS' => ['$(inherited)', '${PODS_ROOT}/../../node_modules/react-native/ReactCommon/yoga']
+      'DEFINES_MODULE' => 'YES'
   }
   spec.compiler_flags = [
       '-fno-omit-frame-pointer',