Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue#504 #506

Merged
merged 1 commit into from
Mar 8, 2024
Merged

fix issue#504 #506

merged 1 commit into from
Mar 8, 2024

Conversation

sancppp
Copy link
Contributor

@sancppp sancppp commented Mar 6, 2024

fix #504

Copy link
Member

@cfc4n cfc4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have consulted a lot of information and I am not sure if these errors can be skipped. However, many open-source projects also choose to skip errors and continue processing. So, I agree with your modification. If anyone else knows about this issue, please answer me as well.

ref:

  1. https://github.com/DataDog/datadog-agent/blob/85871eadd769876875e715f71634ff638caae649/pkg/network/go/asmscan/scan.go#L118
  2. https://github.com/golang/go/blob/69583738eb73ef928a07a1e215b719823fd27aa9/src/cmd/internal/objfile/disasm.go#L357
  3. https://github.com/grafana/beyla/blob/490a82c1af954babd3188af6aff011f0fda70401/pkg/internal/goexec/instructions_arm64.go#L15

However, I suggest adding comments to facilitate others' understanding of the reasons for the modifications.

user/config/config_gotls.go Outdated Show resolved Hide resolved
@cfc4n cfc4n added bug Something isn't working enhancement New feature or request labels Mar 8, 2024
Copy link
Member

@cfc4n cfc4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@cfc4n cfc4n merged commit 5fcf2ad into gojue:master Mar 8, 2024
6 checks passed
@sancppp sancppp deleted the fix_bug branch March 8, 2024 14:10
@sancppp
Copy link
Contributor Author

sancppp commented Mar 9, 2024

I have consulted a lot of information and I am not sure if these errors can be skipped. However, many open-source projects also choose to skip errors and continue processing. So, I agree with your modification. If anyone else knows about this issue, please answer me as well.

ref:

  1. https://github.com/DataDog/datadog-agent/blob/85871eadd769876875e715f71634ff638caae649/pkg/network/go/asmscan/scan.go#L118
  2. https://github.com/golang/go/blob/69583738eb73ef928a07a1e215b719823fd27aa9/src/cmd/internal/objfile/disasm.go#L357
  3. https://github.com/grafana/beyla/blob/490a82c1af954babd3188af6aff011f0fda70401/pkg/internal/goexec/instructions_arm64.go#L15

However, I suggest adding comments to facilitate others' understanding of the reasons for the modifications.

Can you share your experience on how to find these references quickly?

@cfc4n
Copy link
Member

cfc4n commented Mar 10, 2024

Search arm64asm.Decode in github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gotls: hook dockerd fail
2 participants