Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(openssl/boringssl): remove redundant calculation #267

Merged
merged 3 commits into from
Nov 15, 2022
Merged

chore(openssl/boringssl): remove redundant calculation #267

merged 3 commits into from
Nov 15, 2022
+130 −196

Conversation

blaisewang
Copy link
Contributor

ping @cfc4n

@blaisewang blaisewang force-pushed the chore-remove-redundant-calculation branch from 51c7d12 to a1a62b8 Compare November 14, 2022 13:31
cfc4n
cfc4n reviewed Nov 14, 2022
View reviewed changes
Copy link
Member

@cfc4n cfc4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I must tested it before merged.

@blaisewang blaisewang changed the title chore(openssl): remove redundant calculation chore(openssl/boringssl): remove redundant calculation Nov 14, 2022
@blaisewang blaisewang force-pushed the chore-remove-redundant-calculation branch from 8bdb8bf to 9191189 Compare November 14, 2022 13:48
@blaisewang blaisewang marked this pull request as draft November 14, 2022 13:53
@blaisewang blaisewang force-pushed the chore-remove-redundant-calculation branch from fd77c85 to 24f16df Compare November 15, 2022 11:01
@blaisewang blaisewang marked this pull request as ready for review November 15, 2022 14:02
cfc4n
cfc4n approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@cfc4n cfc4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except boringssl . but it's not your PR.

I'll send a new PR for boringssl.

@cfc4n cfc4n merged commit 8a551a2 into gojue:master Nov 15, 2022
@blaisewang blaisewang deleted the chore-remove-redundant-calculation branch November 15, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfc4n cfc4n cfc4n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blaisewang @cfc4n