Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user/module : use const for SSL masterKey function hook. #217

Merged
merged 1 commit into from
Sep 28, 2022
Merged

user/module : use const for SSL masterKey function hook. #217

merged 1 commit into from
Sep 28, 2022

Conversation

cfc4n
Copy link
Member

@cfc4n cfc4n commented Sep 23, 2022 •
edited
Loading

fixes:#212

  1. SSL_do_handshake for Android.
  2. SSL_write for Linux

SSL_do_handshake was null sometimes on Linux .

Signed-off-by: CFC4N cfc4n.cs@gmail.com

@cfc4n
user/module : use const for SSL masterKey function hook.
c682f24 
1. SSL_do_handshake for Android.
2. SSL_write for Linux

`SSL_do_handshake` was null sometimes on Linux .

Signed-off-by: CFC4N <cfc4n.cs@gmail.com>
@cfc4n cfc4n linked an issue Sep 23, 2022 that may be closed by this pull request
No packet saved in file #212
Closed
@cfc4n cfc4n added the fix bug fix PR label Sep 23, 2022
@cfc4n
Copy link
Member Author

cfc4n commented Sep 23, 2022

test command:
curl -k https://136.232.200.186:8443/

@cfc4n
Copy link
Member Author

cfc4n commented Sep 24, 2022

@zhangbo1882 could you try this PR ?

@blaisewang
Copy link
Contributor

I didn't realize you were using SSL_do_handshake in openssl_tc mode.

In section We Had the TLSv1.3 keys and It Still Didn’t Work, but TLSv1.2 Did of this article, the author suggested to delay 500ms to get all required handshake info when using SSL_do_handshake. But using SSL_write is more stable, I believe.

@cfc4n
Copy link
Member Author

cfc4n commented Sep 25, 2022

SSL_do_handshake

BoringSSL use SSL_do_handshake function in many scene on Android 12 or newer.

this PR is an other issue, different with TLS 1.3 Key

@cfc4n cfc4n merged commit 7b1e8e5 into master Sep 28, 2022
@cfc4n cfc4n deleted the 212-no-packet-saved-in-file branch September 28, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix bug fix PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No packet saved in file
2 participants
@cfc4n @blaisewang