Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user : tls models exit gracefully. #165

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

cfc4n
Copy link
Member

@cfc4n cfc4n commented Aug 8, 2022

fixes : #164
Signed-off-by: CFC4N cfc4n.cs@gmail.com

Signed-off-by: CFC4N <cfc4n.cs@gmail.com>
@cfc4n cfc4n linked an issue Aug 8, 2022 that may be closed by this pull request
@cfc4n cfc4n added the bug Something isn't working label Aug 8, 2022
select {
case err := <-errChan:
return err
go func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe simplify this as

go func() {
    for err := <- errChan {
    }
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good suggestion..

@cfc4n cfc4n merged commit f43cd65 into master Aug 12, 2022
@cfc4n cfc4n deleted the tls-models-exit-gracefully branch August 12, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tls models exit gracefully
2 participants