Fix webui test & warnings

gojek · Oct 4, 2024 · 8b3dc0a · 8b3dc0a
1 parent ad0f5c1
commit 8b3dc0a
Show file tree

Hide file tree

Showing 9 changed files with 972 additions and 548 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -40,13 +40,13 @@ jobs:
       - name: Install Node.js
         uses: actions/setup-node@v1
         with:
-          node-version: '12.x'
+          node-version: '20.x'
       - name: Checkout code
         uses: actions/checkout@v2
       # See https://github.com/actions/cache/blob/master/examples.md#node---yarn
       - name: Get yarn cache directory path
         id: yarn-cache-dir-path
-        run: echo "::set-output name=dir::$(yarn cache dir)"
+        run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
       - uses: actions/cache@v2
         id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
         with:

diff --git a/webui/internal/assets/assets.go b/webui/internal/assets/assets.go
diff --git a/webui/internal/assets/build/work.js b/webui/internal/assets/build/work.js
diff --git a/webui/internal/assets/src/DeadJobs.js b/webui/internal/assets/src/DeadJobs.js
@@ -37,7 +37,7 @@ export default class DeadJobs extends React.Component {
       });
   }
 
-  componentWillMount() {
+  componentDidMount() {
     this.fetch();
   }
 

diff --git a/webui/internal/assets/src/Processes.js b/webui/internal/assets/src/Processes.js
@@ -66,7 +66,7 @@ export default class Processes extends React.Component {
     workerPool: []
   }
 
-  componentWillMount() {
+  componentDidMount() {
     if (this.props.busyWorkerURL) {
       fetch(this.props.busyWorkerURL).
         then((resp) => resp.json()).

diff --git a/webui/internal/assets/src/Queues.js b/webui/internal/assets/src/Queues.js
@@ -12,7 +12,7 @@ export default class Queues extends React.Component {
     queues: []
   }
 
-  componentWillMount() {
+  componentDidMount() {
     if (!this.props.url) {
       return;
     }

diff --git a/webui/internal/assets/src/RetryJobs.js b/webui/internal/assets/src/RetryJobs.js
@@ -31,7 +31,7 @@ export default class RetryJobs extends React.Component {
       });
   }
 
-  componentWillMount() {
+  componentDidMount() {
     this.fetch();
   }
 

diff --git a/webui/internal/assets/src/ScheduledJobs.js b/webui/internal/assets/src/ScheduledJobs.js
@@ -31,7 +31,7 @@ export default class ScheduledJobs extends React.Component {
       });
   }
 
-  componentWillMount() {
+  componentDidMount() {
     this.fetch();
   }